Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1496687: Consistent binding names #2247

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Bug 1496687: Consistent binding names #2247

merged 1 commit into from
Oct 11, 2017

Conversation

spadgett
Copy link
Member

Use the binding name instead of the secret name in the service instances
table to be consistent with the overview and service instance details page.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1496687

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2017
@spadgett
Copy link
Member Author

Travis error looks like a flake:

[ERROR] Command 'bower update --allow-root' failed with rc 1, logs:
bower registry-image-widgets#0.0.14           cached https://github.com/cockpit-project/registry-image-widgets.git#0.0.14
bower registry-image-widgets#0.0.14         validate 0.0.14 against https://github.com/cockpit-project/registry-image-widgets.git#0.0.14
bower angular#1.5.11                         EINVRES Request to https://bower.herokuapp.com/packages/angular failed with 410
make: *** [install] Error 1

[merge]

@spadgett
Copy link
Member Author

Bower requests are failing in Jenkins, too.

bower angular#1.5.11                         EINVRES Request to https://bower.herokuapp.com/packages/angular failed with 410
make: *** [install] Error 1

@spadgett
Copy link
Member Author

Opened #2248 for the bower problem.

@spadgett
Bug 1496687: Consistent binding names
9396acb 
Use the binding name instead of the secret name in the service instances
table to be consistent with the overview and service instance details page.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1496687
@openshift-bot
Copy link

Evaluated for origin web console merge up to 9396acb

@openshift-bot
Copy link

openshift-bot commented Oct 11, 2017 •
edited
Loading

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/333/) (Base Commit: 8ef85f7) (PR Branch Commit: 9396acb)

@openshift-bot openshift-bot merged commit 7fd5c10 into openshift:master Oct 11, 2017
@spadgett spadgett deleted the binding-name branch October 11, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spadgett @openshift-bot @jeff-phillips-18 @openshift-ci-robot